Skip to content

feat(basic): update @routup/basic for routup v5#763

Merged
tada5hi merged 1 commit intomasterfrom
742-basic
Apr 8, 2026
Merged

feat(basic): update @routup/basic for routup v5#763
tada5hi merged 1 commit intomasterfrom
742-basic

Conversation

@tada5hi
Copy link
Copy Markdown
Contributor

@tada5hi tada5hi commented Apr 8, 2026

closes #742

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated README usage examples to reflect current server initialization and request handling patterns.
  • Tests

    • Refactored test suite to use Fetch-style request routing.
    • Updated test assertions to use Fetch Response API properties and methods.
  • Chores

    • Updated routup to v5.0.0-beta.3.
    • Removed supertest and related testing dependencies.

@tada5hi tada5hi merged commit 7a150d5 into master Apr 8, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6e6f0e0a-ed1c-4490-a20f-14aa03773b1c

📥 Commits

Reviewing files that changed from the base of the PR and between 0828d38 and 3fb46b7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • packages/basic/README.md
  • packages/basic/package.json
  • packages/basic/test/unit/module.spec.ts

📝 Walkthrough

Walkthrough

The @routup/basic package is updated to support routup v5's event-based handler API. Changes include switching from Node.js-style (req, res) handlers to async handlers receiving an event object, updating request helper function calls to use event properties, bumping the routup dependency to v5.0.0-beta.3, and refactoring tests from supertest to Fetch API style.

Changes

Cohort / File(s) Summary
Documentation and Dependencies
packages/basic/README.md, packages/basic/package.json
Updated usage example to use serve() entrypoint, switched handler pattern to defineCoreHandler with event objects, updated routup to ^5.0.0-beta.3, removed supertest dependencies, updated request helper calls to event-based accessors.
Test Refactoring
packages/basic/test/unit/module.spec.ts
Replaced supertest-based routing with router.fetch Fetch API style, converted handlers to defineCoreHandler with event objects, updated request helpers to accept event parameter, added createTestRequest helper for constructing Fetch Request objects, adjusted assertions to use Fetch Response API.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Poem

🐰 ✨ From callbacks old to events so new,
The basic package gets its v5 debut,
With event objects and handlers so clean,
The finest migration code has seen!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 742-basic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: update @routup/basic for routup v5

1 participant