Implemented Strict batching #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovats
reviewed
Dec 29, 2019
| * process | ||
| */ | ||
| BatchCollector(int batchSize, boolean enforceStrictBatching, Consumer<List<T>> batchProcessor) { | ||
| this.batchSize = batchSize; |
There was a problem hiding this comment.
We seem to have lost the non-null check:
batchProcessor = requireNonNull(batchProcessor);
|
Thanks for contributing. Could you please add some tests for the strict batching feature when convenient? |
|
Sorry about the jUnit tests. I will be committing them shortly. I had the test written but forgot to commit. I am a bit of newbie with Git. The null check is still on in the new constructor. The previous constructor calls the new on with strict batching set to: false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.