Conversation
| })) | ||
| .then(() => fetchPrograms({ | ||
| user__not: user.user_id, | ||
| })) |
There was a problem hiding this comment.
Since a user should never be able to remove a featured program, this seems unnecessary. The same could be said for the user__not above
There was a problem hiding this comment.
Good point. Removing them both.
There was a problem hiding this comment.
Whoops, apparently they are in fact needed!
| expect(wrapper.find(ProgramCollection).exists()).toBe(true); | ||
| expect(wrapper.find(ProgramCollection).length).toBe(1); | ||
| expect(wrapper.find(ProgramCollection).length).toBe(2); | ||
| expect(wrapper.find(Loader).exists()).toBe(true); |
There was a problem hiding this comment.
I'm not sure that these tests are really asserting the proper thing. Basically, they each pass if any Loader is present. They should be checking that there is a Loader in the specific ProgramCollection which is null for that test
There was a problem hiding this comment.
Yeah, the were a little tighter when there were only two ProgramCollections.
There was a problem hiding this comment.
Added a check that there's only one loader. Still not perfectly specific, but a little better.
2 participants
Adds a "Featured Program" list to the programs page.