Skip to content

Conversation

@cabarnes
Copy link
Member

@cabarnes cabarnes commented Aug 7, 2020

Displays the current plan information for the user. Sets up the logic to handle using access codes to activate the user's plan. Sets individual plans to Coming soon:
image
image

@cabarnes cabarnes requested a review from hbradio August 7, 2020 20:26
@hbradio
Copy link
Contributor

hbradio commented Aug 7, 2020

I like the choice to include the individual plan and mark it "coming soon".

isFetching ? (
<>
<Grid item>
<Skeleton animation="wave" width={300} height={200} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look this up -- very cool.

PXT_HEX_URL: JSON.stringify(process.env.PXT_HEX_URL
|| 'https://rovercode-pxt.s3.us-east-2.amazonaws.com/alpha/rovercode.hex'),
SAVE_DEBOUNCE_TIME: JSON.stringify(process.env.SAVE_DEBOUNCE_TIME),
SUBSCRIPTION_SERVICE: JSON.stringify(process.env.SUBSCRIPTION_SERVICE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest that we define this per branch in the .travis.yml deploys, but I guess that's not a thing. We can just set them in the Travis build settings in their web interface.

Copy link
Contributor

@hbradio hbradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cabarnes cabarnes merged commit 9265142 into alpha Aug 10, 2020
@cabarnes cabarnes deleted the user-subscription branch August 10, 2020 21:00
@cabarnes cabarnes mentioned this pull request Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants