Adding missing distance sensor to cache update #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabarnes
reviewed
Jun 14, 2021
src/components/Workspace.js
Outdated
| sensor.leftLightSensorReading, sensor.rightLightSensorReading, | ||
| sensor.leftLineSensorReading, sensor.rightLineSensorReading); | ||
| sensor.leftLineSensorReading, sensor.rightLineSensorReading, | ||
| sensor.distanceSensorReading); |
Member
There was a problem hiding this comment.
It may make sense at this point to just pass in sensor and have the function use destructuring on the object
Contributor
Author
There was a problem hiding this comment.
Done. We should also refactor the names of the button state variables, but I'll leave that for a separate PR since it spans up through the sensor reducer.
cabarnes
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to record a lesson using the distance sensor and realize the block was always returning
undefined. This fixes the error and improves the test that should have caught it.