Project revamp part 2: Edit

Summary:
Taking a pass at revamping the edit pages in Projects. Specifically:

 - Remove EditMainController
 - Move actions from EditMain to Profile
 - Move properties from EditMain to Profile
 - Move timeline from EditMain to Profile
 - Move Open Tasks from Profile to sidenavicon
 - Add custom icons and colors to timeline

Feel free to bang on this a bit and give feedback, feels generally correct to me.

Test Plan: Edit everything I could on various projects. Check links, timelines, actions.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11421

Author: chadlittle

src/__phutil_library_map__.php

@@ -2204,7 +2204,6 @@
     'PhabricatorProjectDescriptionField' => 'applications/project/customfield/PhabricatorProjectDescriptionField.php',
     'PhabricatorProjectEditDetailsController' => 'applications/project/controller/PhabricatorProjectEditDetailsController.php',
     'PhabricatorProjectEditIconController' => 'applications/project/controller/PhabricatorProjectEditIconController.php',
-    'PhabricatorProjectEditMainController' => 'applications/project/controller/PhabricatorProjectEditMainController.php',
     'PhabricatorProjectEditPictureController' => 'applications/project/controller/PhabricatorProjectEditPictureController.php',
     'PhabricatorProjectEditorTestCase' => 'applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php',
     'PhabricatorProjectFeedController' => 'applications/project/controller/PhabricatorProjectFeedController.php',
@@ -5444,7 +5443,6 @@
     'PhabricatorProjectDescriptionField' => 'PhabricatorProjectStandardCustomField',
     'PhabricatorProjectEditDetailsController' => 'PhabricatorProjectController',
     'PhabricatorProjectEditIconController' => 'PhabricatorProjectController',
-    'PhabricatorProjectEditMainController' => 'PhabricatorProjectController',
     'PhabricatorProjectEditPictureController' => 'PhabricatorProjectController',
     'PhabricatorProjectEditorTestCase' => 'PhabricatorTestCase',
     'PhabricatorProjectFeedController' => 'PhabricatorProjectController',

src/applications/files/controller/PhabricatorFileComposeController.php

@@ -72,7 +72,7 @@ public function processRequest() {
         ));
 
       if ($project_phid) {
-        $edit_uri = '/project/edit/'.$project->getID().'/';
+        $edit_uri = '/project/profile/'.$project->getID().'/';
 
         $xactions = array();
         $xactions[] = id(new PhabricatorProjectTransaction())

src/applications/project/application/PhabricatorProjectApplication.php

@@ -43,7 +43,6 @@ public function getRoutes() {
       '/project/' => array(
         '(?:query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorProjectListController',
         'filter/(?P<filter>[^/]+)/' => 'PhabricatorProjectListController',
-        'edit/(?P<id>[1-9]\d*)/' => 'PhabricatorProjectEditMainController',
         'details/(?P<id>[1-9]\d*)/'
           => 'PhabricatorProjectEditDetailsController',
         'archive/(?P<id>[1-9]\d*)/'

src/applications/project/controller/PhabricatorProjectArchiveController.php

@@ -26,7 +26,7 @@ public function processRequest() {
       return new Aphront404Response();
     }
 
-    $edit_uri = $this->getApplicationURI('edit/'.$project->getID().'/');
+    $edit_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
 
     if ($request->isFormPost()) {
       if ($project->isArchived()) {

src/applications/project/controller/PhabricatorProjectController.php

@@ -7,28 +7,27 @@ public function buildApplicationMenu() {
   }
 
   public function buildSideNavView($for_app = false) {
-    $user = $this->getRequest()->getUser();
+    $viewer = $this->getViewer();
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
     $id = null;
     if ($for_app) {
-      $user = $this->getRequest()->getUser();
       $id = $this->getRequest()->getURIData('id');
       if ($id) {
         $nav->addFilter("profile/{$id}/", pht('Profile'));
         $nav->addFilter("board/{$id}/", pht('Workboard'));
         $nav->addFilter("members/{$id}/", pht('Members'));
         $nav->addFilter("feed/{$id}/", pht('Feed'));
-        $nav->addFilter("edit/{$id}/", pht('Edit'));
+        $nav->addFilter("details/{$id}/", pht('Edit Details'));
       }
       $nav->addFilter('create', pht('Create Project'));
     }
 
     if (!$id) {
       id(new PhabricatorProjectSearchEngine())
-        ->setViewer($user)
+        ->setViewer($viewer)
         ->addNavigationItems($nav->getMenu());
     }
 
@@ -38,13 +37,13 @@ public function buildSideNavView($for_app = false) {
   }
 
   public function buildIconNavView(PhabricatorProject $project) {
-    $user = $this->getRequest()->getUser();
+    $viewer = $this->getViewer();
     $id = $project->getID();
     $picture = $project->getProfileImageURI();
     $name = $project->getName();
 
     $columns = id(new PhabricatorProjectColumnQuery())
-      ->setViewer($user)
+      ->setViewer($viewer)
       ->withProjectPHIDs(array($project->getPHID()))
       ->execute();
     if ($columns) {
@@ -58,9 +57,20 @@ public function buildIconNavView(PhabricatorProject $project) {
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
     $nav->addIcon("profile/{$id}/", $name, null, $picture);
     $nav->addIcon("board/{$id}/", pht('Workboard'), $board_icon);
+
+    $class = 'PhabricatorManiphestApplication';
+    if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
+      $phid = $project->getPHID();
+      $query_uri = urisprintf(
+        '/maniphest/?statuses=%s&allProjects=%s#R',
+        implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
+      $phid);
+      $nav->addIcon(null, pht('Open Tasks'), 'fa-anchor', null, $query_uri);
+    }
+
     $nav->addIcon("feed/{$id}/", pht('Feed'), 'fa-newspaper-o');
     $nav->addIcon("members/{$id}/", pht('Members'), 'fa-group');
-    $nav->addIcon("edit/{$id}/", pht('Edit'), 'fa-pencil');
+    $nav->addIcon("details/{$id}/", pht('Edit Details'), 'fa-pencil');
 
     return $nav;
   }

src/applications/project/controller/PhabricatorProjectEditDetailsController.php

@@ -149,13 +149,8 @@ public function processRequest() {
             ));
         }
 
-        if ($is_new) {
-          $redirect_uri =
-            $this->getApplicationURI('profile/'.$project->getID().'/');
-        } else {
-          $redirect_uri =
-            $this->getApplicationURI('edit/'.$project->getID().'/');
-        }
+        $redirect_uri =
+          $this->getApplicationURI('profile/'.$project->getID().'/');
 
         return id(new AphrontRedirectResponse())->setURI($redirect_uri);
       } catch (PhabricatorApplicationTransactionValidationException $ex) {
@@ -304,7 +299,7 @@ public function processRequest() {
 
     if (!$is_new) {
       $nav = $this->buildIconNavView($project);
-      $nav->selectFilter("edit/{$id}/");
+      $nav->selectFilter("details/{$id}/");
       $nav->appendChild($form_box);
     } else {
       $nav = array($form_box);

src/applications/project/controller/PhabricatorProjectEditIconController.php

@@ -26,7 +26,7 @@ public function processRequest() {
       if (!$project) {
         return new Aphront404Response();
       }
-      $cancel_uri = $this->getApplicationURI('edit/'.$project->getID().'/');
+      $cancel_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
       $project_icon = $project->getIcon();
     } else {
       $this->requireApplicationCapability(

src/applications/project/controller/PhabricatorProjectEditMainController.php

@@ -28,7 +28,7 @@ public function processRequest() {
       return new Aphront404Response();
     }
 
-    $edit_uri = $this->getApplicationURI('edit/'.$project->getID().'/');
+    $edit_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
     $view_uri = $this->getApplicationURI('profile/'.$project->getID().'/');
 
     $supported_formats = PhabricatorFile::getTransformableImageFormats();