Delete all "force chunking" file upload code

Summary: Ref T7149. This was just to make testing easier, but chunking substantially works now.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7149

Differential Revision: https://secure.phabricator.com/D12076

Author: epriestley

src/applications/files/conduit/FileAllocateConduitAPIMethod.php

@@ -17,9 +17,6 @@ public function defineParamTypes() {
       'contentLength' => 'int',
       'contentHash' => 'optional string',
       'viewPolicy' => 'optional string',
-
-      // TODO: Remove this, it's just here to make testing easier.
-      'forceChunking' => 'optional bool',
     );
   }
 
@@ -39,8 +36,6 @@ protected function execute(ConduitAPIRequest $request) {
     $view_policy = $request->getValue('viewPolicy');
     $length = $request->getValue('contentLength');
 
-    $force_chunking = $request->getValue('forceChunking');
-
     $properties = array(
       'name' => $name,
       'authorPHID' => $viewer->getPHID(),
@@ -93,14 +88,6 @@ protected function execute(ConduitAPIRequest $request) {
     $engines = PhabricatorFileStorageEngine::loadStorageEngines($length);
     if ($engines) {
 
-      if ($force_chunking) {
-        foreach ($engines as $key => $engine) {
-          if (!$engine->isChunkEngine()) {
-            unset($engines[$key]);
-          }
-        }
-      }
-
       // Pick the first engine. If the file is small enough to fit into a
       // single engine without chunking, this will be a non-chunk engine and
       // we'll just tell the client to upload the file.

src/applications/files/controller/PhabricatorFileDropUploadController.php

@@ -42,9 +42,6 @@ public function processRequest() {
         'name' => $name,
         'contentLength' => $request->getInt('length'),
         'viewPolicy' => $view_policy,
-
-        // TODO: Remove.
-        // 'forceChunking' => true,
       );
 
       $result = id(new ConduitCall('file.allocate', $params))