Skip to content

fix: don't wait stale timeout#5

Merged
jakobrosenberg merged 1 commit intoroxiness:masterfrom
knopki:fix-dont-wait-timeout
Oct 1, 2020
Merged

fix: don't wait stale timeout#5
jakobrosenberg merged 1 commit intoroxiness:masterfrom
knopki:fix-dont-wait-timeout

Conversation

@knopki
Copy link
Copy Markdown
Contributor

@knopki knopki commented Oct 1, 2020

Clear event timeout if event already fired. This saves big amount of time in spank after all work is already done.

TImeout is set to 10000. Before:

time spank
✔ Found matching config: Routify 2
✔ found user config: spank.config.js
✔ Inline dynamic imports
✔ Exported 7 pages in 916 ms
4.61user 0.14system 0:12.89elapsed 36%CPU (0avgtext+0avgdata 206348maxresident)k
0inputs+784outputs (0major+54695minor)pagefaults 0swaps

After:

time spank
✔ Found matching config: Routify 2
✔ found user config: spank.config.js
✔ Inline dynamic imports
✔ Exported 7 pages in 890 ms
4.34user 0.14system 0:02.90elapsed 154%CPU (0avgtext+0avgdata 205408maxresident)k
0inputs+784outputs (0major+56510minor)pagefaults 0swaps

10 seconds faster.

@jakobrosenberg
Copy link
Copy Markdown
Member

Thanks @knopki. Great catch!

@jakobrosenberg jakobrosenberg merged commit f79c3e6 into roxiness:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants