Skip to content

Conversation

@JoOkuma
Copy link
Member

@JoOkuma JoOkuma commented Aug 4, 2025

Hey @TeunHuijben,

I created this PR based on our discussion last week.

I have mixed feelings about using __getitem__ of BaseGraph, I like the interface, but it's hard to generalize to edges.
Any suggestions? Maybe node(node_id=<VALUE>)?

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.02%. Comparing base (a1cd2c3) to head (cec39a2).

Files with missing lines Patch % Lines
src/tracksdata/graph/_base_graph.py 77.77% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   88.08%   88.02%   -0.06%     
==========================================
  Files          49       49              
  Lines        3214     3232      +18     
  Branches      541      542       +1     
==========================================
+ Hits         2831     2845      +14     
- Misses        228      231       +3     
- Partials      155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoOkuma JoOkuma merged commit 536da28 into royerlab:main Aug 14, 2025
7 checks passed
@JoOkuma JoOkuma deleted the jookuma/scalar-api branch August 14, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants