Skip to content

Making attr_key required for GraphArrayView#176

Merged
JoOkuma merged 3 commits intoroyerlab:mainfrom
yfukai:solve_gav_bug
Oct 20, 2025
Merged

Making attr_key required for GraphArrayView#176
JoOkuma merged 3 commits intoroyerlab:mainfrom
yfukai:solve_gav_bug

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Oct 19, 2025

The default value of attr_key in GraphArrayView was bbox, which hardly made sense considering that the value should be a scalar value to display in the mask. It may make more sense to make this required and also check if the prop is a scalar value.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.96%. Comparing base (a188502) to head (bfd77e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   87.95%   87.96%   +0.01%     
==========================================
  Files          50       50              
  Lines        3411     3416       +5     
  Branches      585      586       +1     
==========================================
+ Hits         3000     3005       +5     
  Misses        247      247              
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfukai yfukai marked this pull request as ready for review October 20, 2025 02:03
Copy link
Copy Markdown
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yfukai, thanks for fixing this issue and adding the regression tests.
I don't know how it went through.
I made a single change to fix a missing argument type.

Comment thread src/tracksdata/utils/_dtypes.py Outdated
@JoOkuma JoOkuma merged commit aa29345 into royerlab:main Oct 20, 2025
7 checks passed
@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Oct 20, 2025

Thanks for fixing the PR and merging! @JoOkuma

@yfukai yfukai deleted the solve_gav_bug branch October 24, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants