Skip to content

Renaming "track_id" to "tracklet_id"#179

Merged
JoOkuma merged 4 commits intoroyerlab:mainfrom
yfukai:return_tracklet_id_mapping
Oct 22, 2025
Merged

Renaming "track_id" to "tracklet_id"#179
JoOkuma merged 4 commits intoroyerlab:mainfrom
yfukai:return_tracklet_id_mapping

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Oct 22, 2025

This may be a bit opinionated, but it might make sense to rename all track_id to tracklet_id for consistent terminology. (We already have tracklet_nodes and tracklet_graph).

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.95181% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.03%. Comparing base (ea2026c) to head (eee1798).

Files with missing lines Patch % Lines
src/tracksdata/metrics/_ctc_metrics.py 50.00% 2 Missing and 2 partials ⚠️
src/tracksdata/graph/_rustworkx_graph.py 78.57% 1 Missing and 2 partials ⚠️
src/tracksdata/io/_numpy_array.py 90.47% 1 Missing and 1 partial ⚠️
src/tracksdata/graph/_base_graph.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          50       50           
  Lines        3444     3444           
  Branches      596      596           
=======================================
  Hits         3032     3032           
  Misses        248      248           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoOkuma
Copy link
Copy Markdown
Member

JoOkuma commented Oct 22, 2025

Hi @yfukai, I completely agree, thanks for the PR.
Can I merge it?

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Oct 22, 2025

Thanks @JoOkuma , sure!

@JoOkuma JoOkuma merged commit 06d104e into royerlab:main Oct 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants