Implementing union operation for mask#181
Merged
JoOkuma merged 3 commits intoroyerlab:mainfrom Oct 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 88.03% 88.09% +0.06%
==========================================
Files 50 50
Lines 3444 3462 +18
Branches 596 597 +1
==========================================
+ Hits 3032 3050 +18
Misses 248 248
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoOkuma
reviewed
Oct 23, 2025
| ------- | ||
| Mask | ||
| The union mask between the two masks. | ||
| """ |
Member
There was a problem hiding this comment.
@yfukai, could we do something if the masks have different ndim?
We could err or assume the missing dimensions are 1.
I'm leaning more towards error because I don't see any case where they would have different ndim on purpose.
Contributor
Author
There was a problem hiding this comment.
I think raising an error is a safer path!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's useful to have a union function
mask = mask1 | mask2for track editing. I hope this makes sense!