Fix from_others issue with SQLgraph.#182
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 88.22% 88.17% -0.05%
==========================================
Files 51 51
Lines 3593 3612 +19
Branches 617 625 +8
==========================================
+ Hits 3170 3185 +15
- Misses 254 256 +2
- Partials 169 171 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Minimizing changes of PR royerlab#182
…x_sqlgraph_save_issue
|
|
||
| for col in node_attrs.columns: | ||
| if col != DEFAULT_ATTR_KEYS.T: | ||
| graph.add_node_attr_key(col, node_attrs[col].first()) |
There was a problem hiding this comment.
Maybe this should be inherited from the other graph? Or we can handle this with a new PR.
There was a problem hiding this comment.
@yfukai, unfortunately, we don't store the default value at the graph level. This is something I want to add when reworking the add_node_attr_key to have something better.
Do you see another way of getting it from the other graph?
|
@yfukai, thanks. I left a reply to your comment. If you can inherit the existing information, that would be great. I'm going to rework the Let's remove the I'm trying to fix the benchmark at #190 , without much success. |
|
Hi @JoOkuma, Thanks!
This sounds great! I don't have an idea other than saving a dict of attr_key -> default_value mapping in graphs... |
|
We can work on regionprops default value a bit more (since some props are array-typed) but I created another issue (#191) for that. |
|
Hi @JoOkuma thank you for your comment! For me this PR is fine to be merged! |
Graphs generated by
RegionPropsNodescould not be converted fromRustWorkXGraphtoSQLGraph. This PR intends to solve this issue. This is a quick fix, and later it may make sense to refactor the overall logic.I also updated
currytopartialsince I believe the later is sufficient here.