Changed successors and predecessors so that they return IDs.#188
Merged
JoOkuma merged 7 commits intoroyerlab:mainfrom Nov 13, 2025
Merged
Changed successors and predecessors so that they return IDs.#188JoOkuma merged 7 commits intoroyerlab:mainfrom
JoOkuma merged 7 commits intoroyerlab:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 88.17% 88.05% -0.13%
==========================================
Files 51 51
Lines 3612 3632 +20
Branches 625 633 +8
==========================================
+ Hits 3185 3198 +13
- Misses 256 261 +5
- Partials 171 173 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yfukai
commented
Nov 5, 2025
Contributor
Author
|
This is also ready! @JoOkuma |
…cessor_predecessor_nodeids
JoOkuma
requested changes
Nov 12, 2025
Comment on lines
+667
to
+688
| if isinstance(attr_keys, str): | ||
| attr_keys = [attr_keys] | ||
| valid_schema = None | ||
| neighbors: dict[int, pl.DataFrame] = {} | ||
| for node_id in node_ids: | ||
| neighbors_indices = neighbors_func(rx_graph, node_id) | ||
| neighbors_data: list[dict[str, Any]] = [rx_graph[i] for i in neighbors_indices] | ||
|
|
||
| if attr_keys is not None: | ||
| neighbors_data = [ | ||
| {k: edge_data[k] for k in attr_keys if k != DEFAULT_ATTR_KEYS.NODE_ID} | ||
| for edge_data in neighbors_data | ||
| ] | ||
|
|
||
| if attr_keys is not None: | ||
| neighbors_data = [ | ||
| {k: edge_data[k] for k in attr_keys if k != DEFAULT_ATTR_KEYS.NODE_ID} | ||
| for edge_data in neighbors_data | ||
| ] | ||
|
|
||
| if len(neighbors_data) > 0: | ||
| df = pl.DataFrame(neighbors_data) | ||
| if attr_keys is None or DEFAULT_ATTR_KEYS.NODE_ID in attr_keys: | ||
| df = df.with_columns( | ||
| pl.Series(DEFAULT_ATTR_KEYS.NODE_ID, np.asarray(neighbors_indices, dtype=int)), | ||
| ) | ||
| neighbors[node_id] = df | ||
| valid_schema = neighbors[node_id].schema | ||
| if len(neighbors_data) > 0: | ||
| df = pl.DataFrame(neighbors_data) | ||
| if attr_keys is None or DEFAULT_ATTR_KEYS.NODE_ID in attr_keys: | ||
| df = df.with_columns( | ||
| pl.Series(DEFAULT_ATTR_KEYS.NODE_ID, np.asarray(neighbors_indices, dtype=int)), | ||
| ) | ||
| neighbors[node_id] = df | ||
| valid_schema = neighbors[node_id].schema |
Member
There was a problem hiding this comment.
I think we could reduce the amount of code duplication when return_attrs=True by querying the indices with a call of the same function with return_attrs=False and then querying the dataframes. What do you think?
Contributor
Author
There was a problem hiding this comment.
Yeah that was also an option which is better maybe. Let me try on that track!
Member
There was a problem hiding this comment.
LGTM, I just renamed a variable. Once the test passes, I'll merge, thanks for the PR!
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
Contributor
Author
|
Hi @JoOkuma, this may not be exactly the same as what you meant but I tried to reduce the code duplicates! Could you review the udpated code? |
JoOkuma
reviewed
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187.
API and Interface Updates
return_attrsparameter (defaulting toFalse) tosuccessorsandpredecessorsmethods insrc/tracksdata/graph/_base_graph.py, updating their overloads and documentation to clarify return types for both node IDs and attributes._rustworkx_graph.py,_sql_graph.py,_graph_view.py) to propagate thereturn_attrsparameter and handle both return modes, including changes to_get_neighborsand related methods.Internal Logic and Performance
return_attrsisFalse, only node IDs are returned, avoiding unnecessary DataFrame creation and improving efficiency for large graphs.