Using np.nextafter instead of eps#189
Merged
JoOkuma merged 22 commits intoroyerlab:mainfrom Nov 5, 2025
Merged
Conversation
This reverts commit 6988d91.
…ply-tiled_nextafter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 88.22% 88.22% -0.01%
==========================================
Files 51 51
Lines 3593 3592 -1
Branches 617 617
==========================================
- Hits 3170 3169 -1
Misses 254 254
Partials 169 169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Now it's ready to review @JoOkuma! The edge case fails with the previous impl but succeeds with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the tile slicing logic in the
_yield_apply_tiledfunction withinsrc/tracksdata/functional/_apply.pyto improve numerical precision and ensure correct handling of inclusive and exclusive ranges. The most important changes are:Tile slicing precision improvements:
eps) for adjusting slice end points withnp.nextafter, which more accurately converts inclusive to exclusive ranges based on floating-point precision. This change affects both the calculation ofslicing_without_overlapand the mainslicinglogic.