Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 88.17% 88.14% -0.04%
==========================================
Files 51 51
Lines 3612 3669 +57
Branches 625 630 +5
==========================================
+ Hits 3185 3234 +49
- Misses 256 262 +6
- Partials 171 173 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yfukai
left a comment
yfukai
left a comment
There was a problem hiding this comment.
The changes looks good to me, thanks!
Minor comments:
- Could we also implement
def remove_metadata(self, key)? shapeargument ofGraphArrayViewconstructor andto_ctccan also be omitted. It would be great ifRegionPropsNodesandfrom_ctcsaves theshapeattribute.
|
Hi @yfukai, great suggestions! I addressed your comments. |
yfukai
left a comment
yfukai
left a comment
There was a problem hiding this comment.
Everything looks nice to me! I left a comment on a lazy import. Maybe the reason for importing lazily can be explained by a comment.
| node_ids: list[int] | None = None, | ||
| return_id_update: bool = False, | ||
| ) -> rx.PyDiGraph | tuple[rx.PyDiGraph, pl.DataFrame]: | ||
| from tracksdata.functional._rx import _assign_tracklet_ids |
There was a problem hiding this comment.
Why was this changed to lazy import?
There was a problem hiding this comment.
I added a note, it's local to avoid circular import
|
Oh but the tests are failing... |
|
As soon as the test runs I think this PR is good to go! |
|
Thank @yfukai |
3 participants
@yfukai, could you review this PR?
It should address item 2 of #192
I added the option of automatically querying the shape to export it to napari.
This was requested internally