Skip to content

Ensuring graph array view implements LayerDataProtocol for napari#198

Merged
JoOkuma merged 2 commits intoroyerlab:mainfrom
yfukai:ensure_layer_data_protocol
Nov 12, 2025
Merged

Ensuring graph array view implements LayerDataProtocol for napari#198
JoOkuma merged 2 commits intoroyerlab:mainfrom
yfukai:ensure_layer_data_protocol

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Nov 11, 2025

Having size property is required for multiscale rendering.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.18%. Comparing base (75f28d6) to head (2970dd4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   88.17%   88.18%           
=======================================
  Files          51       51           
  Lines        3612     3615    +3     
  Branches      625      625           
=======================================
+ Hits         3185     3188    +3     
  Misses        256      256           
  Partials      171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoOkuma
Copy link
Copy Markdown
Member

JoOkuma commented Nov 11, 2025

Hey @yfukai, is this ready for review?
It looks ready to me.
Some of your other PRs are also marked as draft.

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Nov 11, 2025

Sorry I forgot to mark this ready!

@yfukai yfukai marked this pull request as ready for review November 11, 2025 21:22
@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Nov 11, 2025

This is now ready! @JoOkuma

@JoOkuma JoOkuma merged commit ecde7e4 into royerlab:main Nov 12, 2025
7 checks passed
@JoOkuma
Copy link
Copy Markdown
Member

JoOkuma commented Nov 12, 2025

@yfukai merged, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants