Fix benchmark (and migrate to ASV)#199
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 54 54
Lines 3856 3856
Branches 665 665
=======================================
Hits 3407 3407
Misses 268 268
Partials 181 181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TODOs:
|
|
The benchmark artifact is still not valid but at least the benchmark task is running! |
JoOkuma
left a comment
There was a problem hiding this comment.
@yfukai this is amazing!
I was able to access the artifacts they look good to me.
I left a minor comment regarding the show_progress.
Do you think we could reduce the number of samples it run the benchmark?
It took 34 min to run the whole thing.
The github summary is super useful, do you think it could be formatted in markdown?
Thanks a bunch for this PR.
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
|
todo:
|
|
Thanks a lot @yfukai, the ratio in the summary is super helpful! |
Fix the benchmark and migrate to ASV