Skip to content

Fix benchmark (and migrate to ASV)#199

Merged
JoOkuma merged 35 commits intoroyerlab:mainfrom
yfukai:fix_benchmark
Dec 9, 2025
Merged

Fix benchmark (and migrate to ASV)#199
JoOkuma merged 35 commits intoroyerlab:mainfrom
yfukai:fix_benchmark

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Nov 12, 2025

Fix the benchmark and migrate to ASV

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.35%. Comparing base (06b4588) to head (b5bc04c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   88.35%   88.35%           
=======================================
  Files          54       54           
  Lines        3856     3856           
  Branches      665      665           
=======================================
  Hits         3407     3407           
  Misses        268      268           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Nov 12, 2025

TODOs:

  • Review asv config
  • Fix workflow

Comment thread asv.conf.json
@yfukai yfukai marked this pull request as ready for review December 1, 2025 05:46
@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Dec 1, 2025

The benchmark artifact is still not valid but at least the benchmark task is running!

Copy link
Copy Markdown
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yfukai this is amazing!

I was able to access the artifacts they look good to me.

I left a minor comment regarding the show_progress.

Do you think we could reduce the number of samples it run the benchmark?
It took 34 min to run the whole thing.

The github summary is super useful, do you think it could be formatted in markdown?

Thanks a bunch for this PR.

Comment thread benchmarks/graph_backends.py Outdated
yfukai and others added 2 commits December 2, 2025 09:02
Co-authored-by: Jordão Bragantini <jordao.bragantini@gmail.com>
@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Dec 3, 2025

todo:

  • organize the report
  • further shorten the run for CI, looking at the env

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Dec 9, 2025

Hi @JoOkuma, I believe this is good to be merged! I gave up on asv publish since the result from the asv continuous is not really helpful. Instead I generated the comparison table in the summary. Feedbacks are welcome!

@JoOkuma
Copy link
Copy Markdown
Member

JoOkuma commented Dec 9, 2025

Thanks a lot @yfukai, the ratio in the summary is super helpful!

@JoOkuma JoOkuma merged commit d3d23d3 into royerlab:main Dec 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants