Retrieving pickle dtype to avoid sqlgraph mask update error#200
Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom Nov 17, 2025
Merged
Retrieving pickle dtype to avoid sqlgraph mask update error#200JoOkuma merged 1 commit intoroyerlab:mainfrom
JoOkuma merged 1 commit intoroyerlab:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 88.00% 88.24% +0.23%
==========================================
Files 51 51
Lines 3686 3692 +6
Branches 638 641 +3
==========================================
+ Hits 3244 3258 +14
+ Misses 267 261 -6
+ Partials 175 173 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the handling of pickled column types in SQL-based graph backends, ensuring that columns storing pickled Python objects (such as custom masks) are correctly restored after reloading from disk. The changes also add a test to verify this behavior.
Persistence and restoration of pickled column types:
_restore_pickled_column_typesmethod to theMetadataclass, which scans table columns and restores anyLargeBinarycolumns to usePickleTypeupon table loading. This ensures that custom Python objects remain deserializable after database reloads.Baseclass to invoke_restore_pickled_column_typesfor each table when not overwriting, so column types are restored before ORM class creation.Testing improvements:
test_sql_graph_mask_update_survives_reloadtest to ensure that a pickledMaskobject can be updated and retrieved correctly after reloading the SQL database, verifying the persistence fix.