Skip to content

Fix dtype issue with bbox in SQLGraph#212

Merged
JoOkuma merged 2 commits intoroyerlab:mainfrom
yfukai:sqlgraph_bbox_array
Dec 1, 2025
Merged

Fix dtype issue with bbox in SQLGraph#212
JoOkuma merged 2 commits intoroyerlab:mainfrom
yfukai:sqlgraph_bbox_array

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Nov 21, 2025

For some cases the bbox column of SQLGraph becomes "pl.List" dtype, causing index out of range error. This is a tentative fix for this issue. After we implement #193 we will be able to remove this cast safely.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.25%. Comparing base (e87a375) to head (4195520).

Files with missing lines Patch % Lines
src/tracksdata/graph/filters/_spatial_filter.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   88.29%   88.25%   -0.04%     
==========================================
  Files          53       53              
  Lines        3809     3815       +6     
  Branches      661      662       +1     
==========================================
+ Hits         3363     3367       +4     
- Misses        266      267       +1     
- Partials      180      181       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yfukai , LGTM.
Can I merge this?

@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented Dec 1, 2025

Thanks, yes! @JoOkuma

@JoOkuma JoOkuma merged commit 3df89e2 into royerlab:main Dec 1, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants