Skip to content

Allows node_ids=None for successors and predecessors#225

Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom
yfukai:none_for_suc_pred
Dec 10, 2025
Merged

Allows node_ids=None for successors and predecessors#225
JoOkuma merged 1 commit intoroyerlab:mainfrom
yfukai:none_for_suc_pred

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented Dec 10, 2025

This pull request enhances the graph API by allowing the successors and predecessors methods to accept None as the node_ids argument, which will query all nodes in the graph. The implementation is updated across all graph backends, and comprehensive tests are added to verify the new behavior.

Closes #206.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.38%. Comparing base (06b4588) to head (9181636).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tracksdata/graph/_graph_view.py 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   88.35%   88.38%   +0.03%     
==========================================
  Files          54       54              
  Lines        3856     3866      +10     
  Branches      665      669       +4     
==========================================
+ Hits         3407     3417      +10     
+ Misses        268      267       -1     
- Partials      181      182       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yfukai LGTM!

@JoOkuma JoOkuma merged commit 6cf2df9 into royerlab:main Dec 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supporting node_ids = None for predecessors and successors

3 participants