Conversation
Contributor
Author
|
Two questions for @JoOkuma:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 88.40% 88.37% -0.04%
==========================================
Files 55 55
Lines 3873 3940 +67
Branches 674 690 +16
==========================================
+ Hits 3424 3482 +58
- Misses 267 276 +9
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hi @TeunHuijben, I did my review as PR in #233 , can you check if you agree with them? |
* improving testing * removing old comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, (un)pickling the graphView gave problems, because the
_edge_from_{from/to}_rootbidict got duplicated and was no longer coupled.In this PR, we add
getstate/setstatemethods to the GraphView and mappedGraphMixin to make the bidict picklable.