Skip to content

graphview.bulk_add_edges actually uses ._root.bulk_add_edges#272

Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom
TeunHuijben:fix-graphview-bulk-add-edges
Mar 25, 2026
Merged

graphview.bulk_add_edges actually uses ._root.bulk_add_edges#272
JoOkuma merged 1 commit intoroyerlab:mainfrom
TeunHuijben:fix-graphview-bulk-add-edges

Conversation

@TeunHuijben
Copy link
Copy Markdown
Contributor

GraphView.bulk_add_edges called BaseGraph.bulk_add_edges, which actually looped over all edges to perform add_edge individually.

This PR changes that GraphView.bulk_add_edges actually uses ._root.bulk_add_edges, which is a lot faster (especially for on-disk SQL graphs on linux)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.29%. Comparing base (1564427) to head (8bf0d51).

Files with missing lines Patch % Lines
src/tracksdata/graph/_graph_view.py 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   87.34%   87.29%   -0.06%     
==========================================
  Files          56       56              
  Lines        4703     4713      +10     
  Branches      829      832       +3     
==========================================
+ Hits         4108     4114       +6     
- Misses        379      380       +1     
- Partials      216      219       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeunHuijben TeunHuijben marked this pull request as ready for review March 25, 2026 22:32
@TeunHuijben TeunHuijben requested a review from JoOkuma March 25, 2026 22:32
@JoOkuma JoOkuma merged commit 47f450a into royerlab:main Mar 25, 2026
7 checks passed
@TeunHuijben TeunHuijben deleted the fix-graphview-bulk-add-edges branch March 25, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants