graphview.bulk_add_edges actually uses ._root.bulk_add_edges#272
Merged
JoOkuma merged 1 commit intoroyerlab:mainfrom Mar 25, 2026
Merged
graphview.bulk_add_edges actually uses ._root.bulk_add_edges#272JoOkuma merged 1 commit intoroyerlab:mainfrom
JoOkuma merged 1 commit intoroyerlab:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 87.34% 87.29% -0.06%
==========================================
Files 56 56
Lines 4703 4713 +10
Branches 829 832 +3
==========================================
+ Hits 4108 4114 +6
- Misses 379 380 +1
- Partials 216 219 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphView.bulk_add_edgescalled BaseGraph.bulk_add_edges, which actually looped over all edges to performadd_edgeindividually.This PR changes that
GraphView.bulk_add_edgesactually uses._root.bulk_add_edges, which is a lot faster (especially for on-disk SQL graphs on linux)