fix unpickle_bytes_columns crash on variable-size binary columns#273
Merged
JoOkuma merged 2 commits intoroyerlab:mainfrom Mar 26, 2026
Merged
fix unpickle_bytes_columns crash on variable-size binary columns#273JoOkuma merged 2 commits intoroyerlab:mainfrom
JoOkuma merged 2 commits intoroyerlab:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 87.29% 87.33% +0.04%
==========================================
Files 56 56
Lines 4713 4713
Branches 832 832
==========================================
+ Hits 4114 4116 +2
+ Misses 380 378 -2
Partials 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_elements without return_dtype infers the column type from the first deserialized element. When a binary column contains numpy arrays of different shapes (e.g. cell masks after a GEFF roundtrip), polars locks in the type from the first array and raises SchemaError on any subsequent array with a different shape.
The function already had a fallback loop to handle variable-size objects — it was simply unreachable because map_elements crashed before returning.
Fix: add return_dtype=pl.Object to skip type inference. The existing fallback loop then re-casts uniform columns to typed polars Series and silently keeps variable-size columns as pl.Object.
Regression test: test_unpickle_bytes_columns_variable_size_arrays — two differently-shaped bool arrays in a binary column, previously raised SchemaError.