Skip to content

Optimization#274

Merged
JoOkuma merged 7 commits intoroyerlab:mainfrom
TeunHuijben:optimization
Mar 27, 2026
Merged

Optimization#274
JoOkuma merged 7 commits intoroyerlab:mainfrom
TeunHuijben:optimization

Conversation

@TeunHuijben
Copy link
Copy Markdown
Contributor

Changes:

  • SQLGraph.update_node_attrs(): put more code within the is_signal_on block

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (65f3a74) to head (a310fe8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files          56       56           
  Lines        4713     4715    +2     
  Branches      832      831    -1     
=======================================
+ Hits         4116     4118    +2     
  Misses        378      378           
  Partials      219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/tracksdata/nodes/_mask.py Outdated
@TeunHuijben
Copy link
Copy Markdown
Contributor Author

TeunHuijben commented Mar 27, 2026

@JoOkuma, this might be ready for merge

I checked from funtracks, and the Mask.__get_state was 19% faster 😮 (in the current state, versus the np.options hack)

@TeunHuijben TeunHuijben marked this pull request as ready for review March 27, 2026 18:03
@JoOkuma JoOkuma merged commit 8a6b5e6 into royerlab:main Mar 27, 2026
7 checks passed
@TeunHuijben TeunHuijben deleted the optimization branch March 27, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants