Skip to content

Refactoring #281 #295

Open
yfukai wants to merge 7 commits into
royerlab:mainfrom
yfukai:large_query_v2
Open

Refactoring #281 #295
yfukai wants to merge 7 commits into
royerlab:mainfrom
yfukai:large_query_v2

Conversation

@yfukai
Copy link
Copy Markdown
Contributor

@yfukai yfukai commented May 27, 2026

This is an attempt to refactor #281 on the current main. I updated the code to merge overlapping functions.

Original context:

I got the same error as #249 when I did graph.filter(node_ids=node_ids), and this is intended to solve the issue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

❌ Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.81%. Comparing base (a4f7607) to head (0cfec4d).

Files with missing lines Patch % Lines
src/tracksdata/graph/_sql_graph.py 94.25% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   87.75%   87.81%   +0.06%     
==========================================
  Files          57       57              
  Lines        4947     4998      +51     
  Branches      872      877       +5     
==========================================
+ Hits         4341     4389      +48     
- Misses        381      384       +3     
  Partials      225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfukai yfukai marked this pull request as ready for review May 27, 2026 12:37
@yfukai
Copy link
Copy Markdown
Contributor Author

yfukai commented May 27, 2026

I think this is ready! @JoOkuma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants