Implement SetDutyCycle generically on ChannelId #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue rp-rs#907 showed that SetDutyCycle was difficult to use because its implementation depends on whether it's an A or B channel. This change avoids the requirement to manually specify the channel type. It also removes some unnecessary code duplication.
cantudo
pushed a commit
to cantudo/rp-hal
that referenced
this pull request
May 19, 2025
* Implement SetDutyCycle generically on ChannelId Issue rp-rs#907 showed that SetDutyCycle was difficult to use because its implementation depends on whether it's an A or B channel. This change avoids the requirement to manually specify the channel type. It also removes some unnecessary code duplication. * Remove some more code duplication in PWM implementation * Copy changes to pwm code from rp2040-hal to rp235x-hal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #907 showed that SetDutyCycle was difficult to use because its implementation depends on whether it's an A or B channel.
This change avoids the requirement to manually specify the channel type.
It also removes some unnecessary code duplication.