chrome treats touchstart/touchmove event as passive #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krmbn0576
reviewed
Mar 17, 2017
js/rpg_core/Utils.js
Outdated
| // https://github.com/WICG/EventListenerOptions/blob/gh-pages/explainer.md#feature-detection | ||
| var passive = false; | ||
| var options = Object.defineProperty({}, "passive", { | ||
| get() { passive = true; } |
Collaborator
There was a problem hiding this comment.
MV corescript shouldn't use ES6 or more!
Can you rewrite this line to ES5?
ghost
approved these changes
Mar 25, 2017
ghost
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Chrome 56+ treats touchstart/touchmove event as passive default.
So,
preventDefault()has no effect at passive event.https://www.chromestatus.com/feature/5093566007214080
Solve
Test this browser support passive, and set
passive: falseif support.