Test for downgrade/upgrade exit codes #700
Conversation
| And stderr is | ||
| """ | ||
| Package flac of lowest version already installed, cannot downgrade it. | ||
| """ |
There was a problem hiding this comment.
Wouldn't this be better split into multiple scenarios? The main difference being the scenarios would be run independently, here the first fail causes the rest not to be run. Since this even tests two different commands (upgrade/downgrade), I think it would be better to split into smaller pieces.
For the common setup these tests have, Given I use repository "dnf-ci-fedora-updates" is shared with all the scenarios, so that can go into Background. And then "dnf-ci-fedora" is only required for a couple of tests it seems.
Otherwise LGTM.
There was a problem hiding this comment.
One of the goals for this test was to make sure that upgrade/downgrade commands behave consistently - that they return the same exit code in the same situations. So I would like to keep them together. But I agree the scenario could be split into three (four) independent tests - non existent package, not installed package, already on highest (lowest) version. The background bit of course could be done.
There was a problem hiding this comment.
Eventually I've split them into multiple scenarios.
DNF now return 0 when the downgraded package is already on the lowest available version.
2 participants
No description provided.