Add at least the first two feature_layouts in xsave_layout_from_trace.#4069
Merged
rocallahan merged 1 commit intoApr 28, 2026
Conversation
This fixes a regression introduced by 2c1d0b2, which gets only visible if no supported_feature_bits are set above the first two bits, which is the case for a Intel Pentium B950 from 2011. There it surfaces in the tcp_sockets test, with the dump crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by 2c1d0b2,
which gets only visible if no supported_feature_bits are set above the first two bits,
which is the case for a Intel Pentium B950 from 2011. There it surfaces in the tcp_sockets test, with the dump crashing.
Backtrace of the SIGSEGV and some notes I took are in attached file:
debugging.txt
CC: @theIDinside