HookWidget.debugFillProperties using HookState.diagnosticsProperty

[kranfix]

In the package example, the widget inspector for the useState example shows nothing about the hook state:

With this new feature, if these lines are added to the _StateHookState, this will be shown int the widget inspector.

class _StateHookState<T> extends HookState<ValueNotifier<T>, _StateHook<T>> {
  ValueNotifier<T> _state;

 ///...

  @override
  DiagnosticsProperty get diagnosticsProperty {
    return DiagnosticsProperty<T>('useState<$T>', _state.value);
  }
}

[codecov]

Codecov Report

Merging #178 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   99.62%   99.67%   +0.05%     
==========================================
  Files          10       10              
  Lines         531      616      +85     
==========================================
+ Hits          529      614      +85     
  Misses          2        2              

Impacted Files	Coverage Δ
lib/src/animation.dart	100.00% <100.00%> (ø)
lib/src/async.dart	100.00% <100.00%> (ø)
lib/src/focus.dart	100.00% <100.00%> (ø)
lib/src/framework.dart	100.00% <100.00%> (ø)
lib/src/listenable.dart	100.00% <100.00%> (ø)
lib/src/misc.dart	98.33% <100.00%> (+0.41%)	⬆️
lib/src/primitives.dart	100.00% <100.00%> (ø)
lib/src/scroll_controller.dart	100.00% <100.00%> (ø)
lib/src/tab_controller.dart	100.00% <100.00%> (ø)
lib/src/text_controller.dart	95.23% <100.00%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4054ed0...dd17638. Read the comment docs.

[rrousselGit]

Thanks!

We will need some tests for this.

[kranfix]

According to the coverage/lcov.info, the HookElement.debugFillProperties is covered. Any suggestion for adding a local tests for this feature?

[rrousselGit]

Hook probably should be Diagnosticable too.

[kranfix]

What's the need to make Hook diagnosticable?

StatelessWidget is Diagnosticable, but StatefulWidget isn't. Instead, State is Diagnosticable. In this case, Hook is like StatefulWidget and HookState is like State.

[rrousselGit]

Covered doesn't mean tested. We need a test that verifies that debugFillProperties works correctly.

A good start may be to have some existing hooks override debugFillProperties, like useState/useMemoized, and test that it works properly.

[kranfix]

I don't find a way to test the debugFillProperties. Do you have any suggestion?

[kranfix]

@rrousselGit I found a way to test de debugFillProperties . I'll be sending new commits on weekend.

[kranfix]

Tests for useState and useMemoized where added

[rrousselGit]

Thanks, sorry for the delay.
I'll merge that and deploy it later this week. I need to make some extra changes

[rrousselGit]

I'll do that tomorrow.
I plan to add Diagnistics for all hooks at once.

And the Diagnostics must be updated such that we can have:

HookBuilder
 │ useMemoized<int>: 43
 | useAnimationController: AnimationController#00000
 | └duration: Duration(seconds: 2)
 └SizedBox(renderObject: RenderConstrainedBox#00000)