-
-
Notifications
You must be signed in to change notification settings - Fork 191
HookWidget.debugFillProperties using HookState.diagnosticsProperty #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rrousselGit
merged 15 commits into
rrousselGit:master
from
kranfix:debug_fill_properties
Sep 6, 2020
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1c5467f
HookWidget.debugFillProperties using HookState.diagnosticsProperty
kranfix 683a689
Refactor HookState.diagnosticsProperty to HookState.debugFillProperties
kranfix a445eb7
HookState now implements Diagnosticable
kranfix 18e43c6
Fix: HookState doesn't implement Diagnosticable, but also use it as m…
kranfix 18a128f
debugFillProperties for memoized hook
kranfix a1d54ec
debugFillProperties for state hook
kranfix 763a079
Merge branch 'master' of https://github.com/rrousselGit/flutter_hooks…
kranfix 6fadf22
useState appears in debugFillProperties
kranfix 826a495
adding linter ignore comment_references for docs
kranfix c6b9095
testing state hook change
kranfix c683310
debugFillProperties test for useMemoized
kranfix be90be6
Merge branch 'master' into debug_fill_properties
rrousselGit fd59dac
Merge branch 'master' into debug_fill_properties
rrousselGit 51649c0
closes #15
rrousselGit dd17638
Remove dead code
rrousselGit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hook probably should be Diagnosticable too.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the need to make
Hookdiagnosticable?StatelessWidgetisDiagnosticable, butStatefulWidgetisn't. Instead,StateisDiagnosticable. In this case,Hookis likeStatefulWidgetandHookStateis likeState.