Nullable reference types support by andrewvk · Pull Request #129 · rsdn/CodeJam

andrewvk · 2020-11-21T10:46:21Z

No description provided.

# Conflicts: # Build/JetBrains.Annotations.cs # CodeJam.Experimental.Tests/UseCases/TempDataUseCases.cs # CodeJam.Main/Arithmetic/OperatorsFactory.cs # CodeJam.Main/Assertions/Code.cs # CodeJam.Main/Assertions/CodeExceptions.cs # CodeJam.Main/Assertions/DebugCode.generated.cs # CodeJam.Main/CodeJam.Main.csproj # CodeJam.Main/Collections/SuffixTree/SuffixTreeBase.cs # CodeJam.Main/Expressions/ExpressionExtensions.cs # CodeJam.Main/Reflection/MemberAccessor.cs # CodeJam.Main/Strings/StringExtensions.cs # CodeJam.Main/Threading/ParallelQueue.cs # CodeJam.sln.DotSettings

andrewvk · 2020-11-21T11:12:02Z

Feel free to apply changes from previous PR.

andrewvk · 2020-11-25T12:44:20Z

One more interesting point. R# automatically removes its own CanBeNull markup when adding "?" to a type. @NN---

NN--- · 2020-11-25T13:47:31Z

I paid attention to that:)
As I said my concern is old ReSharper versions without good NRT support.

NN--- · 2021-01-11T18:29:14Z

@andrewvk So, do we agree that all ReSharper nullability attributes will be replaced with .NET nullability attributes ?

Enable nullability in all projects.

NN--- · 2021-01-17T18:52:30Z

Btw, IDictionary doesn't require "TKey : notnull" according to sources.
https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IDictionary.cs

It means adding this constraint is not correct.

Coding style fixes.

andrewvk · 2021-01-17T19:35:02Z

You mean that NUnit still doesn't have a NotNull attribute markup? Yeah, that's pretty weird. Of course, in this case it's worth adding your own variant.

andrewvk · 2021-01-17T19:39:11Z

NN--- · 2021-01-17T19:41:59Z

Yeah. I tried to reproduce this in a separate project but everything compiled.
Probably it requires this constraint only for specific framework.
Currently everything compiles but not in appveyor:(
I’ll check how to improve it.

andrewvk · 2021-01-17T19:42:01Z

Core 3.0 library

Core 5.0 library

Shall we try to hide it under a compiler directive?

andrewvk · 2021-01-17T19:43:37Z

#if NETCOREAPP3_1 where TKey : notnull #endif
Build OK

…into feature/nullable_v3

NN--- · 2021-01-17T20:11:28Z

It is better to not introduce additional constraint if possble

…encyInjection).

NN--- · 2021-01-18T19:44:38Z

Fixed recursion and now the build works :)
@andrewvk Is there anything left in PR ?

andrewvk and others added 10 commits August 30, 2020 19:31

Working on nullability support

f62d0ad

Merge branch 'master' into feature/nullable_v3

b0b7985

Working on nullability

21b1db2

Working on nullability

6045fe2

Working on nullability-2

953ea29

Working on nullability-3

99974a6

Working on nullability

f3fbccf

Working on nullability

b9afc0b

Working on nullability

eebafae

andrewvk requested review from NN--- and ig-sinicyn November 21, 2020 10:46

NN--- requested changes Nov 21, 2020

View reviewed changes

Comment thread Build/Build.csproj Outdated

Merge remote-tracking branch 'origin/master' into feature/nullable_v3

cf9851d

andrewvk and others added 5 commits November 26, 2020 00:24

Working on NRT markup

e6a96a7

Working on NRT markup

ade72b6

Working on NRT markup

02b82ab

Fix tests

c8d6050

Fix NRT

461e17b

NN--- reviewed Dec 7, 2020

View reviewed changes

Comment thread CodeJam.Main/ConnectionStrings/ConnectionStringBase.ConnectionWrapper.cs

NN--- added 6 commits January 11, 2021 20:59

Use .NET nullability attributes and C# syntax.

bf786ca

Enable nullability in all projects.

More nullable annotations.

813c4ba

Add nullability annotations

dbf9a03

Add nullability annotations

76859b8

Add nullability annotations

dd15d32

Add nullability annotations

ff117eb

NN--- added 2 commits January 17, 2021 20:54

Remove IDE messages.

60b6788

Remove useless IDE hints.

12bd1f2

Coding style fixes.

andrewvk added 2 commits January 17, 2021 23:08

IDictionary notnull only for Core 3

7407d42

Merge branch 'feature/nullable_v3' of https://github.com/rsdn/CodeJam …

6321f93

…into feature/nullable_v3

andrewvk and others added 15 commits January 17, 2021 23:15

Fix warning

d17f400

Remove Blocks serviceprovider helpers (superseded by Microsoft.Depend…

8a5a503

…encyInjection).

Update readmes

6846ed0

Fix Main tests

2ff32df

Simplify nullability

9ec8fee

Introduce NAssert - NRT compatible Assert.

31a1511

Remove suppressions.

6e6a430

Remove unused namespace.

c75ba91

Naming style.

a06613d

Fix analysis.

e9684c1

Fix code suggestions

3bbcc64

Fix IDE messages.

1ea1224

Suppress inspections

715e3d9

Fix tests.

3c950aa

Convert ReSharper DotSettings settings into editorconfig.

b79abe2

Use nameof instead of strings.

cf13a78

andrewvk merged commit 297a838 into master Jan 18, 2021

NN--- deleted the feature/nullable_v3 branch July 13, 2021 05:17

Conversation

andrewvk commented Nov 21, 2020

Uh oh!

Uh oh!

andrewvk commented Nov 21, 2020

Uh oh!

andrewvk commented Nov 25, 2020

Uh oh!

NN--- commented Nov 25, 2020

Uh oh!

Uh oh!

NN--- commented Jan 11, 2021

Uh oh!

NN--- commented Jan 17, 2021

Uh oh!

andrewvk commented Jan 17, 2021

Uh oh!

andrewvk commented Jan 17, 2021

Uh oh!

NN--- commented Jan 17, 2021

Uh oh!

andrewvk commented Jan 17, 2021

Uh oh!

andrewvk commented Jan 17, 2021

Uh oh!

NN--- commented Jan 17, 2021

Uh oh!

NN--- commented Jan 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants