Skip to content

Index/Range Cleanup #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Index/Range Cleanup #138

wants to merge 6 commits into from

Conversation

@andrewvk
Copy link
Member

@andrewvk andrewvk commented Jun 20, 2021

No description provided.

@andrewvk andrewvk requested review from NN--- and ig-sinicyn June 20, 2021 19:02
NN---
NN--- reviewed Jun 20, 2021
View reviewed changes
@NN---
Copy link
Member

NN--- commented Jun 21, 2021

I think it is better to push Index/Range to Theraot library.
I can port them and ask to publish new NuGet.

@andrewvk
Copy link
Member Author

andrewvk commented Jun 24, 2021

I think it is better to push Index/Range to Theraot library.
I can port them and ask to publish new NuGet.

This will delay our release till the release of theraot. Is it OK?

@NN---
Copy link
Member

NN--- commented Jun 24, 2021

I think it is better to push Index/Range to Theraot library.
I can port them and ask to publish new NuGet.

This will delay our release till the release of theraot. Is it OK?

The developer is very friendly, so I don't see an issue here.

@NN---
Copy link
Member

NN--- commented Jun 27, 2021

Ported to Theraot .
Will ask for a NuGet update after build succeeds.

@NN---
Copy link
Member

NN--- commented Jul 8, 2021

Theraot 3.2.7 includes Range and Index.

@NN--- NN--- changed the title Index/range targeting. Cleanup. Index/Range Cleanup Jul 13, 2021
NN--- added a commit that referenced this pull request Jul 13, 2021
@NN---
Merge #138 changes
1c63a5a
@NN---
Copy link
Member

NN--- commented Jul 13, 2021

Added ranges to master.

@NN--- NN--- closed this Jul 13, 2021
@NN---
Copy link
Member

NN--- commented Jul 14, 2021

@andrewvk @ig-sinicyn Can we release 4.0 now ?

@NN--- NN--- deleted the feature/range_targeting branch October 27, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NN--- NN--- NN--- left review comments

@ig-sinicyn ig-sinicyn Awaiting requested review from ig-sinicyn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewvk @NN---