Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps EnvStack to version 1.0.2 and focuses on developer workflow improvements for running tests locally while also hardening the encryption helper module to better tolerate missing cryptography dependencies and avoid return-in-finally warnings.
Changes:
- Bump project version to 1.0.2 in
pyproject.tomlandlib/envstack/__init__.py. - Add a
make pytesttarget intended to mirror CI’s editable-install test flow. - Update
lib/envstack/encrypt.pyto removereturnstatements fromfinallyblocks and introduce fallback symbols/classes for optionalcryptographyimports.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml |
Version bump to 1.0.2. |
Makefile |
Adds pytest target and updates .PHONY targets. |
lib/envstack/encrypt.py |
Optional crypto import hardening; remove returns from finally; adjust InvalidTag handling. |
lib/envstack/__init__.py |
Version bump to 1.0.2. |
CHANGELOG.md |
Document 1.0.2 release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to version 1.0.2, focusing on improving the test workflow and hardening the encryption helpers. The main improvements include adding a new Makefile target for running tests in editable mode, updating the handling of optional cryptography dependencies to prevent errors, and removing problematic
returnstatements fromfinallyblocks to avoid Python warnings.Test workflow improvements:
pytesttarget to theMakefilethat installs the package in editable mode before running the test suite, matching CI behavior..PHONYtargets in theMakefileto includepytest.Encryption helper fixes and hardening:
returnstatements fromfinallyblocks in encryption helpers to avoid newer PythonSyntaxWarnings. [1] [2]cryptographyimports by defining fallback classes and variables so missing crypto dependencies do not break exception handling paths. Updated exception handling to use these fallbacks. [1] [2] [3]Version bump:
pyproject.tomlandlib/envstack/__init__.py. [1] [2]Changelog update:
CHANGELOG.mdto document the new version and its changes.