Skip to content

Conversation

@rsgalloway
Copy link
Owner

@rsgalloway rsgalloway commented Apr 13, 2025

Version 0.8.8 RC

This was linked to issues Apr 13, 2025
@rsgalloway rsgalloway requested a review from Copilot April 13, 2025 22:52
@rsgalloway rsgalloway self-assigned this Apr 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.



def evaluate_modifiers(expression: str, environ: dict = os.environ):
def evaluate_modifiers(expression: str, environ: dict = os.environ, parent: dict = {}):
Copy link

Copilot AI Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using a mutable default argument for 'parent'. Use 'None' as the default and assign a new dict inside the function instead.

Copilot uses AI. Check for mistakes.
@rsgalloway rsgalloway merged commit 10aafe9 into master Apr 13, 2025
@rsgalloway rsgalloway deleted the issue58/inherited-environments branch April 13, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some included values are clobbered smarter file caching

2 participants