Add JRuby support for gem build and release#249
Merged
yahonda merged 1 commit intorsim:masterfrom Apr 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds JRuby-specific gem packaging and updates the release workflow to build and publish both CRuby and JRuby variants, while making ruby-oci8 a CRuby-only runtime dependency.
Changes:
- Update gemspec to set platform to
javaon JRuby and addruby-oci8as a CRuby runtime dependency. - Add a JRuby gem build job to the GitHub Actions release workflow.
- Update the release job to download and push both built gem artifacts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ruby-plsql.gemspec | Adds JRuby platform targeting and moves ruby-oci8 to a CRuby-only runtime dependency. |
| .github/workflows/release.yml | Builds a JRuby gem artifact and pushes both CRuby + JRuby gems on tag releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda
force-pushed
the
add-jruby-support
branch
from
780af86 to
48b88f8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruby-oci8as a runtime dependency only for CRuby (was a dev dependency for all platforms)javaon JRubyFollows the same approach as rsim/oracle-enhanced@22f0e67.
Test plan
gem build ruby-plsql.gemspecsucceeds on both CRuby and JRuby🤖 Generated with Claude Code