Prefer ActiveRecord.default_timezone over per-class accessor

[yahonda]

Summary

Calling ar_class.default_timezone on Rails 7.0.x prints

DEPRECATION WARNING: ActiveRecord::Base.default_timezone is deprecated
and will be removed in Rails 7.1. Use `ActiveRecord.default_timezone`
instead.

even though both accessors return the same value.

Switch the order in PLSQL::Schema#default_timezone so that we ask the
module-level ActiveRecord.default_timezone first when it is available
(AR 7.0+, and the only accessor left in AR 7.1+) and only fall back to
the per-class accessor on pre-7.0 AR where the module-level one does
not exist.

Fixes #234

Affected Rails versions

• Rails 7.0.x — emits the deprecation warning in user code that configures plsql.activerecord_class.
• Rails 7.1+ — the per-class ActiveRecord::Base.default_timezone accessor was removed entirely in commit rails/rails@96c9db1 (March 2023). With it gone, ar_class.respond_to?(:default_timezone) returns false and the existing fallback path in PLSQL::Schema#default_timezone already uses ActiveRecord.default_timezone — so 7.1/7.2/8.0 users were never seeing the warning. The fix still applies cleanly for them and is a no-op behavior-wise.
• Rails ≤ 6.x — ActiveRecord.default_timezone doesn't exist; the per-class fallback continues to be used. No behavior change.

Behavior change

On AR 7.0+, a user who set MyModel.default_timezone = :utc (the
deprecated per-class API) and then plsql.activerecord_class = MyModel
previously had that per-class override honored. After this change the
module-level ActiveRecord.default_timezone is consulted instead and
the per-class override is ignored. This matches the direction Rails
itself is moving (AR 7.1 removed the per-class accessor entirely) and
silences the deprecation warning rather than emulating the deprecated
API.

Test plan

• Verified by [verify] #268 test fails without fix (do not merge) #269 / [verify] #268 test fails without fix on rebased master (do not merge) #271 that the new spec fails on AR 7.0 without
  this fix (deprecation warning surfaces from lib/plsql/schema.rb:107)
  and passes on AR 7.1+ with or without the fix (since the deprecated
  accessor is no longer present).
• Confirm test_gemfiles matrix passes on AR 5.0 through AR 8.0.
• Confirm the deprecation warning no longer appears on AR 7.0 in
  user code that configures plsql.activerecord_class.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR updates PLSQL::Schema#default_timezone to prefer the Rails 7+ module-level ActiveRecord.default_timezone API (avoiding the Rails 7.0/7.1 deprecation warning from ActiveRecord::Base.default_timezone), with a fallback for older ActiveRecord versions.

Changes:

• Reordered timezone lookup in PLSQL::Schema#default_timezone to use ActiveRecord.default_timezone first when available.
• Added a regression spec to assert no ActiveRecord::Base.default_timezone deprecation warning is emitted on Rails versions that support the module-level accessor.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
lib/plsql/schema.rb	Prefer ActiveRecord.default_timezone to avoid Rails 7 deprecation warnings; keep fallback for older AR.
spec/plsql/schema_spec.rb	Add test coverage to ensure plsql.default_timezone does not emit the deprecated warning.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.