Set continue-on-error: false for ruby_head and truffleruby workflows#270
Merged
yahonda merged 1 commit intorsim:masterfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the scheduled “preview Ruby” CI workflows so that failures in ruby_head and truffleruby runs surface as actual workflow failures, instead of being masked by continue-on-error.
Changes:
- Set
continue-on-error: falsefor thebuildjob in theruby_headscheduled workflow. - Set
continue-on-error: falsefor thebuildjob in thetrufflerubyscheduled workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ruby_head.yml | Makes scheduled Ruby head/debug failures fail the workflow by disabling job-level continue-on-error. |
| .github/workflows/truffleruby.yml | Makes scheduled TruffleRuby failures fail the workflow by disabling job-level continue-on-error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Flip continue-on-error from true to false on the ruby_head and truffleruby workflows so that a failed CI job actually fails the suite. continue-on-error: true makes job results "green even when red", and in practice failures under that mode tend to be ignored — defeating the purpose of running the job at all. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda
force-pushed
the
set-continue-on-error-false
branch
from
9ff2bd9 to
6c8623c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip
continue-on-errorfromtruetofalseon theruby_headandtrufflerubyscheduled workflows so that a failed CI job actually fails the suite.In practice,
continue-on-error: truemakes job results "green even when red" and failures under that mode tend to get ignored — defeating the purpose of running the job at all. We'd rather see a real red status when a head/preview Ruby genuinely breaks.A companion change for the PR-gating workflows (
test,test_11g,test_11g_ojdbc11,jruby_head) is in #259.Test plan
🤖 Generated with Claude Code