Remove unused result_new local in get_ruby_value_from_result_set#273
Merged
yahonda merged 1 commit intorsim:masterfrom Apr 20, 2026
Merged
Conversation
Running specs under `RUBYOPT=-w` (e.g. JRuby head CI) surfaced:
lib/plsql/jdbc_connection.rb:381: warning: assigned but unused
variable - result_new
The variable was assigned but never read; the method already returned
the converted value. Dropping the assignment silences the warning
without changing behavior.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes an unused local variable assignment in get_ruby_value_from_result_set that triggers a Ruby warning under RUBYOPT=-w, without changing behavior.
Changes:
- Remove the unused
result_newlocal by returningora_value_to_ruby_value(ora_value)directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_ruby_value_from_result_setassigned its return value to a localresult_newthat was never read.RUBYOPT=-w(seen on the JRuby head CI job) this producedlib/plsql/jdbc_connection.rb:381: warning: assigned but unused variable - result_new.lib/plsql/jdbc_connection.rb:222still receives the converted Ruby value).Test plan
ruby -c lib/plsql/jdbc_connection.rbpasses.jdbc_connection.rb:381warning is gone.spec/plsql/procedure_spec.rb,spec/plsql/sql_statements_spec.rb) still pass against a live Oracle DB.Remaining warnings in that CI run originate from activesupport / activerecord / JRuby and are out of scope for this repo.
Generated with Claude Code