Skip to content

Declare compatibility with advanced adapter to 1.5.x and activerecord to 4.1.x#62

Merged
javornikolov merged 2 commits into
masterfrom
bump-up-dependency-advanced-adapter-to-1.5-activerecord-4.1
Oct 4, 2014
Merged

Declare compatibility with advanced adapter to 1.5.x and activerecord to 4.1.x#62
javornikolov merged 2 commits into
masterfrom
bump-up-dependency-advanced-adapter-to-1.5-activerecord-4.1

Conversation

@javornikolov
Copy link
Copy Markdown
Collaborator

Declare compatibility with oracle advanced adapter 1.5.x and activerecord 4.1.x.

/cc @rsim @yahonda

Declare support for oracle advanced adapter 1.5.x and activerecord 1.4.x
Declare compatibility with oracle advanced adapter 1.5.x and activerecord 1.4.x
@yahonda
Copy link
Copy Markdown
Collaborator

yahonda commented Oct 3, 2014

Thanks for your active work.

activerecord-oracle_enhanced-adapter 1.5 just supports Rails 4.0 and 4.1.
For those who wants to use ruby-plsql with Rails 3.2 or lower ruby-plsql needs another branch to support it.

@javornikolov
Copy link
Copy Markdown
Collaborator Author

activerecord-oracle_enhanced-adapter 1.5 just supports Rails 4.0 and 4.1.
For those who wants to use ruby-plsql with Rails 3.2 or lower ruby-plsql needs another branch to support it.

I declared the dependencies as a range:
'activerecord', '>= 3.2.3', '< 4.2.0'
'activerecord-oracle_enhanced-adapter', '>= 1.4.1', '< 1.6.0'

So same version should be able to work with any of Rails 3.2, 4.0, 4.1.

@rsim
Copy link
Copy Markdown
Owner

rsim commented Oct 3, 2014

If ruby-plsql can support both oracle_enhanced 1.4 / Rails 3.x and oracle_enhanced 1.5 / Rails 4.x then it would be nice :)

@yahonda
Copy link
Copy Markdown
Collaborator

yahonda commented Oct 3, 2014

@javornikolov It was my bad. Tested and this commit works with ActiveRecord 3.2.19 and 4.1.6. :shipit:

@javornikolov
Copy link
Copy Markdown
Collaborator Author

Yes, I also tested with both. Now I'm running the tests with an intermediate version of ActiveRecord 4.0.10/Adapter 1.5.5 (just in case).

javornikolov added a commit that referenced this pull request Oct 4, 2014
…to-1.5-activerecord-4.1

Declare compatibility with advanced adapter to 1.5.x and activerecord to 4.1.x
@javornikolov javornikolov merged commit ec23d29 into master Oct 4, 2014
@javornikolov javornikolov modified the milestone: 0.5.1 Oct 11, 2014
@javornikolov javornikolov deleted the bump-up-dependency-advanced-adapter-to-1.5-activerecord-4.1 branch February 16, 2016 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants