Immutable record default values utilities #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface/record, update testing deps
brandongregoryscott
added
enhancement
myty
approved these changes
Jun 22, 2021
| /** | ||
| * Omit all keys from `TSource` that intersect with `TExclusion` | ||
| */ | ||
| type OmitKeys<TSource, TExclusion> = Omit<TSource, keyof TExclusion>; |
src/utilities/record-utils.ts
Outdated
| * @param maybeRecords Array of objects or Records to be coalesced into Records. | ||
| * @param record Type of the Record to be instantiated | ||
| */ | ||
| ensureRecords<T>(maybeRecords: any[], record: Constructor<T>): T[] { |
Contributor
There was a problem hiding this comment.
Thought: What if this was more strongly typed? Something like this:
ensureRecords<TValue, TRecord extends TValue>(
maybeRecords: TValue[],
record: Constructor<TRecord>
): TRecord[]
Contributor
Author
There was a problem hiding this comment.
I don't see why it couldn't be - let me try it out 👍
dylanjustice
approved these changes
Jun 22, 2021
Contributor
|
Love the |
Contributor
Author
|
@all-contributors add @dylanjustice for review |
Contributor
|
I've put up a pull request to add @dylanjustice! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129 AuditableDefaultValues / Factory for requiring properties to be set
defaultValuesFactorywhich essentially just provides typing to ensure consumer doesn't miss any properties of typeTauditableDefaultValuesFactorywhich does the same, but also provides defined properties forAuditablesensureRecordswhich takes an array of objects and maps it throughensureRecord, which is common for view model constructors to do for navigation properties