Enable java-client to cpp-server tck tests #344
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lehecka has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
benjchristensen
pushed a commit
that referenced
this pull request
Apr 22, 2017
* Address lint warnings Lint warnings: single-argument constructors not marked explicit * Added tests for the v/ version. * Added a test for ->take() * Fix open source build Reviewed By: yschimke Differential Revision: D4921941 fbshipit-source-id: 1d7e2d13d78f2318c82ce67c00b73d0e641c0395 * Address lint warnings Lint warnings: single-argument constructors not marked explicit * Added tests for the v/ version. * Added a test for ->take() * Switched CMake version, to get past travis build * Use std::size_t instead of size_t * Fix build error (detected in travis) * Remove dependency on reactivestreams * Took out build-problematic typedef * Moved Wrapper out of Flowable, to fix the build * Add workaround for (old) gcc bug With lambdas in subclass methods invoking methods defined in a superclass, gcc (pre-6) complains of methods not having proper visibility. * Thread libraries for yarpl tests * Merged tests, disabled failing one * Added yarpl/tests to travis * Enable java-client to cpp-server tck tests Summary: cpp-client to java-server tck tests dont work yet Closes #344 Differential Revision: D4928525 Pulled By: lehecka fbshipit-source-id: 0c747080ad13d60a729acaefd584534aa6ba6278 * Address lint warnings Lint warnings: single-argument constructors not marked explicit * Added tests for the v/ version. * Added a test for ->take() * Switched CMake version, to get past travis build * Use std::size_t instead of size_t * Fix build error (detected in travis) * Remove dependency on reactivestreams * Took out build-problematic typedef * Moved Wrapper out of Flowable, to fix the build * Add workaround for (old) gcc bug With lambdas in subclass methods invoking methods defined in a superclass, gcc (pre-6) complains of methods not having proper visibility. * Thread libraries for yarpl tests * Merged tests, disabled failing one * Added yarpl/tests to travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp-client to java-server tck tests dont work yet