Further updates to the v/ version of Flowable #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vjn
commented
Apr 20, 2017
vjn
commented
- Added subscribeOn operator.
- Added additional methods in Subscribers::create()
- Added a first set of tests.
Lint warnings: single-argument constructors not marked explicit
Reviewed By: yschimke Differential Revision: D4921941 fbshipit-source-id: 1d7e2d13d78f2318c82ce67c00b73d0e641c0395
Lint warnings: single-argument constructors not marked explicit
With lambdas in subclass methods invoking methods defined in a superclass, gcc (pre-6) complains of methods not having proper visibility.
Contributor
|
LGTM. Pulling in to fbcode. |
|
@lehecka has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: cpp-client to java-server tck tests dont work yet Closes #344 Differential Revision: D4928525 Pulled By: lehecka fbshipit-source-id: 0c747080ad13d60a729acaefd584534aa6ba6278
Lint warnings: single-argument constructors not marked explicit
With lambdas in subclass methods invoking methods defined in a superclass, gcc (pre-6) complains of methods not having proper visibility.
|
@lehecka has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
Contributor
|
This PR broke the Travis build (asan-detected leaks), any plans to fix? @vjn @benjchristensen @lehecka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.