ClientReactiveSocket sends NEXT_COMPLETE after REQUEST_SUBSCRIPTION/REQUEST_RESPONSE/etc.

[lexs]

I'm observing that after REQUEST_SUBSCRIPTION it also sends a RESPONSE frame with the COMPLETE flag set. This is out of spec obviously but might break a less lenient implementation.

This is caused by ClientReactiveSocket passing a Px.just<Payload>() which emits a onComplete() that is handled by RemoteSender (created in handleStreamResponse()) here: https://github.com/ReactiveSocket/reactivesocket-java/blob/b8fd58aaafec022bacc7a9c5f214d720f3535dd1/reactivesocket-core/src/main/java/io/reactivesocket/internal/RemoteSender.java#L162

[NiteshKant]

@lexs thanks for the report. The following is the issue:

• For request-stream and request-subscription it sends a Response NEXT_COMPLETE frame.
• For request-channel, it sends a Response NEXT_COMPLETE, instead it should send a REQUEST_CHANNEL, NEXT_COMPLETE
• No issue for other interaction models.

[robertroeser]

@lexs is this still a problem?

[lexs]

@robertroeser Yes, afaik. It was last week but haven't tested more recently than that.

[robertroeser]

@lexs I believe this is fixed now