switch request/response to send NEXT_COMPLETE instead of a NEXT, and a COMPLETE frame #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix and NEXT_COMPLETE support.
robertroeser
added a commit
that referenced
this pull request
Aug 17, 2015
switch request/response to send NEXT_COMPLETE instead of a NEXT, and a COMPLETE frame
stevegury
added a commit
that referenced
this pull request
Jun 8, 2016
* Refactor Factory to Connector + Implement availability Problem We need to comply with the recent refactoring "Factory to Connector" introduced in reactivesocket-java. Also, implementation of DuplexConnection have to return an availability. Solution The Factory to Connector refactoring is pretty straight forward. All implementations of DuplexConnection return an availability which directly map the state of the underlying resource (0.0 if the resource is closed, 1.0 otherwise). This will greatly help the load-balancer to select a valid connection. I removed the blocking method from reactivesocket-java, so I moved some utility blocking code inside the TestUtil class. Clean-up of the Netty implementation, remove unused args, explicitey specify tcp socket configuration. Shortened the toString name to ease log-reading. Bug All DuplexConnection implementations now cancel the subscription when an exception occurs. This fix the problem, where the Keep-Alive Observable kept trying to send a keep-alive on a closed connection. * Refactor the TestUtil helper to return CompletableFuture * rs version * Restore rs dependency to latest.release * Remove mavenLocal in gradle build file * Propagate cancellation in all cases * Use helper method from ReactiveSocket Unsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.