Properly propagate exceptions type from server client. #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
***Problem*** Errors generated from the `Responder` are serialized according to the spec https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#error-codes but the type is lost when deserializing by the `Requester`. ***Solution*** Instead of generating a RuntimeException containing the string of the error, generate the right Exception type based on the error code. This allow user code, or filter to make smart decision based on the Exception type (Retryable, ...)
stevegury
added a commit
that referenced
this pull request
Jul 15, 2016
***Problem*** There is an error in the Error frame, the error codes used for `APPLICATION_ERROR`, `REJECTED`, `CANCELED` and `INVALID` were invalid. ***Solution*** Update the constants. I don't think it requires doing any version bump, since the error code was not used prior to #150. ***Modification*** I also took the oportunity to review the `frame` package and update it to the Java code style.
robertroeser
pushed a commit
that referenced
this pull request
Jul 15, 2016
***Problem*** There is an error in the Error frame, the error codes used for `APPLICATION_ERROR`, `REJECTED`, `CANCELED` and `INVALID` were invalid. ***Solution*** Update the constants. I don't think it requires doing any version bump, since the error code was not used prior to #150. ***Modification*** I also took the oportunity to review the `frame` package and update it to the Java code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Problem_
Errors generated from the
Responderare serialized according to the spechttps://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#error-codes
but the type is lost when deserialized by the
Requester._Solution_
Instead of generating a RuntimeException containing the string of the error,
generate the right Exception type based on the error code.
This allows user code or filter to make smart decision based on the Exception
type (Retryable, ...)