Fix Error flags to match the spec + review the frame package.
#151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
***Problem*** There is an error in the Error frame, the error codes used for `APPLICATION_ERROR`, `REJECTED`, `CANCELED` and `INVALID` were invalid. ***Solution*** Update the constants. I don't think it requires doing any version bump, since the error code was not used prior to #150. ***Modification*** I also took the oportunity to review the `frame` package and update it to the Java code style.
| public static final int APPLICATION_ERROR = 0x0021; | ||
| public static final int CONNECTION_ERROR = 0x0101; | ||
| public static final int APPLICATION_ERROR = 0x0201; | ||
| public static final int REJECTED = 0x0022; |
stevegury
added a commit
that referenced
this pull request
Jul 15, 2016
It should have been fixed in #151, that was an oversight from my part.
robertroeser
pushed a commit
that referenced
this pull request
Jul 26, 2016
It should have been fixed in #151, that was an oversight from my part.
xytosis
pushed a commit
to xytosis/reactivesocket-java
that referenced
this pull request
Aug 6, 2016
It should have been fixed in rsocket#151, that was an oversight from my part.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
* Make Resume Token Not Present If Flag Not Set This makes the behavior for resume token similar to metadata. If the flag is not set, then the bytes will not exist in the payload. This is discussed in rsocket/rsocket#149 * 65,535 not 65,536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Problem_
There is an error in the Error frame, the error codes used for
APPLICATION_ERROR,CONNECTION_ERROR,REJECTED,CANCELEDandINVALIDwere invalid._Solution_
Update the constants.
I don't think it requires doing any version bump, since the error code was not used
prior to #150.
_Modification_
I also took the oportunity to review the
framepackage and update it to the Javacode style.