Always Reassemble Regardless of MTU #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a user configured a non-positive (<=0) MTU for fragmentation, both fragmentation and reassembly were disabled. Given that a receiver must always be prepared to reassemble fragmented frames (there is no handshake or flag that both parties must agree to) requiring fragmentation to enable reassembly was to strict. This change updates the fragmenter to handle an MTU of size 0 as an indicator that there should be no fragmentation, but still enable reassembly. The RSocketFactory was also updated to ensure that the fragmenter is always added, rather than skipping it when the MTU was zero. [#501]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user configured a non-positive (<=0) MTU for fragmentation, both fragmentation and reassembly were disabled. Given that a receiver must always be prepared to reassemble fragmented frames (there is no handshake or flag that both parties must agree to) requiring fragmentation to enable reassembly was to strict. This change updates the fragmenter to handle an MTU of size 0 as an indicator that there should be no fragmentation, but still enable reassembly. The RSocketFactory was also updated to ensure that the fragmenter is always added, rather than skipping it when the MTU was zero.