Support for rejecting setup #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Sep 23, 2018
| @Override | ||
| public Mono<RSocket> accept(ConnectionSetupPayload setup, RSocket sendingSocket) { | ||
| senderRSockets.onNext(sendingSocket); | ||
| return Mono.error(new RuntimeException(errorMessage)); |
Member
There was a problem hiding this comment.
Why not use RejectedSetupException? As in any other exception is an internal error, but this would indicate a valid we just didn't like this.
n.b. I see you translate elsewhere, so just curious.
Member
Author
There was a problem hiding this comment.
I thought It is not feasible to force (and expect) people use correct exception, so this test verifies any exception is translated to RejectedSetupException
yschimke
reviewed
Sep 23, 2018
| (in, out) -> { | ||
| in.context().addHandler(new RSocketLengthCodec()); | ||
| TcpDuplexConnection connection = new TcpDuplexConnection(in, out, in.context()); | ||
| acceptor.apply(connection).subscribe(); |
Member
There was a problem hiding this comment.
nice! I think this removes a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.